detect-rpc-v1 #5590
Closed
detect-rpc-v1 #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- detect-rpc: convert unit tests to new FAIL/PASS API. - fix unused variable error.
|
Copying from previous, closed PR: I was wondering if some of the longer tests (like 3rd and 5th) shouldn't be split into smaller, more concise ones... |
| if (de_ctx == NULL) { | ||
| goto end; | ||
| } | ||
| FAIL_IF_NULL(de_ctx); | ||
|
|
||
| de_ctx->flags |= DE_QUIET; | ||
|
|
||
| s = de_ctx->sig_list = SigInit(de_ctx,"alert udp any any -> any any (msg:\"RPC Get Port Call\"; rpc:100000, 2, 3; sid:1;)"); |
There was a problem hiding this comment.
Can you make an additional cleanup here?
s = de_ctx->sig_list = SigInit( can be turned into s = DetectEngineAppendSig(
|
Closed with #5591 |
hsadia538
added a commit
to hsadia538/suricata
that referenced
this pull request
Oct 24, 2022
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 27, 2022
benignbala
pushed a commit
to benignbala/suricata
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4056
Previous PR:
#5589
Describe changes:
PRScript output (if applicable):
#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: