Next/50x/20201201/v2 #5625
Merged
Next/50x/20201201/v2 #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the libs specified in LDFLAGS to LDADD put them into the correct placement on in the link command. (cherry picked from commit 10f639e)
Prior to Rust 1.44, Cargo would name static libs with the .lib extension. 1.44 changes this extension to .a when running under a GNU environment on Windows like msys to make it more similar to other unix environments. Now assume static library name to be the same on Windows and unix, but rename the .lib if found to still support older versions of Rust on Windows. (cherry picked from commit f3c59ef)
regit
added a commit
to regit/suricata
that referenced
this pull request
Oct 30, 2022
3 tasks
benignbala
pushed a commit
to benignbala/suricata
that referenced
this pull request
Nov 12, 2022
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5614
#5623
PRScript output (if applicable):
Passed