Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nflog: introduce mnl API v2 #5630

Closed
wants to merge 3 commits into from
Closed

Conversation

glongo
Copy link
Contributor

@glongo glongo commented Dec 6, 2020

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3383

Describe changes:
If libmnl is present on the system, nflog will use the new api otherwise it still relies on the old ones.

PRScript output (if applicable):

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

Check if libmnl is installed on the system.
Use mnl api if available, otherwise still use the old ones.
@glongo glongo requested review from norg and a team as code owners December 6, 2020 14:51
@victorjulien
Copy link
Member

Thanks Giuseppe. What is the advantage of using libmnl?

@catenacyber catenacyber added the needs rebase Needs rebase to master label Mar 10, 2021
@victorjulien
Copy link
Member

Thanks Giuseppe. What is the advantage of using libmnl?

@glongo any feedback on this?

@glongo
Copy link
Contributor Author

glongo commented Apr 14, 2023

Libnfnetlink is deprecated and it's suggested to migrate to libmnl, which is the netlink library used in nftables.

I think it should slightly bring better performance to nflog given its semplicity in handling netlink sockets, but I haven't made any performance tests to confirm that.

If you find these changes interesting, I can rework the patchset and send a new PR.

[1] https://lore.kernel.org/netdev/YkxUru2QG%2Fo1BlTV@orbyte.nwl.cc/T/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
3 participants