Detect prefilter setupu8 4335 v6 #5937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such as >255 for an uint8 field
instead of erroring cf DetectICodeMatchTest01
Codecov Report
@@ Coverage Diff @@
## master #5937 +/- ##
==========================================
+ Coverage 76.67% 76.68% +0.01%
==========================================
Files 604 604
Lines 187828 187821 -7
==========================================
+ Hits 144008 144036 +28
+ Misses 43820 43785 -35
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
reviewed
Mar 4, 2021
| @@ -373,6 +454,10 @@ DetectU8Data *DetectU8Parse (const char *u8str) | |||
| return NULL; | |||
| } | |||
| } | |||
| if (DetectU8Validate(&u8da)) { | |||
| SCLogError(SC_ERR_INVALID_VALUE, "Impossible value for uint8 condition"); | |||
There was a problem hiding this comment.
can we provide a more helpful error here? Something that includes the keyword name and perhaps also the original value?
There was a problem hiding this comment.
Ok for the original value.
For the keyword name, should it be the caller of DetectU32Parse (such as DetectHTTP2windowSetup) which should print another message or should it transmit the keyword name to DetectU32Parse just for this debugging purpose ?
|
Replaced by #5966 |
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Mar 23, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Mar 23, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Mar 23, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 4, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 5, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 18, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 18, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Apr 24, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 4, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 4, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 10, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 10, 2023
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4112
https://redmine.openinfosecfoundation.org/issues/4335
Describe changes:
Modifies #5923 by formatting and rewording commit