Batch backports to 5.0.x #5940
Closed
Batch backports to 5.0.x #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move initialization of filestore global counter to PreRunInit, so they get registered during program initialization, or as required in unix-socket mode, initialized for each file run. Fixes Redmine issue: https://redmine.openinfosecfoundation.org/issues/4216 (cherry picked from commit 7f1e574)
so as to avoid overrecursion leading to stack exhaustion (cherry picked from commit 7500c29)
(cherry picked from commit b7fd01c)
Closed
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 24, 2023
Defrag memcap and flow memcap do not support flow action for the exception policies, as there is no flow when the exception condition is hit. In such cases, the exception policy must be considered for the packet only, when that makes sense, or should be ignored, in case of `bypass`. Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 24, 2023
As flow.memcap-policy and defrag.memcap-policy do not support flow actions, clarify that in the documentation. Also fix some typos, and add missing values in some places where the exception policies were explained. Related to Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 27, 2023
Defrag memcap and flow memcap do not support flow action for the exception policies, as there is no flow when the exception condition is hit. In such cases, the exception policy must be considered for the packet only, when that makes sense, or should be ignored, in case of `bypass`. Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 27, 2023
As flow.memcap-policy and defrag.memcap-policy do not support flow actions, clarify that in the documentation. Also fix some typos, and add missing values in some places where the exception policies were explained. Related to Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 27, 2023
Defrag memcap and flow memcap do not support flow action for the exception policies, as there is no flow when the exception condition is hit. In such cases, the exception policy must be considered for the packet only, when that makes sense, or should be ignored, in case of `bypass`. Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 27, 2023
As flow.memcap-policy and defrag.memcap-policy do not support flow actions, clarify that in the documentation. Also fix some typos, and add missing values in some places where the exception policies were explained. Related to Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 27, 2023
Defrag memcap and flow memcap do not support flow action for the exception policies, as there is no flow when the exception condition is hit. In such cases, the exception policy must be considered for the packet only, when that makes sense, or should be ignored, in case of `bypass`. Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 27, 2023
As flow.memcap-policy and defrag.memcap-policy do not support flow actions, clarify that in the documentation. Also fix some typos, and add missing values in some places where the exception policies were explained. Related to Bug OISF#5940
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Mar 28, 2023
Defrag memcap and flow memcap do not support flow action for the exception policies, as there is no flow when the exception condition is hit. In such cases, the exception policy must be considered for the packet only, when that makes sense, or should be ignored, in case of `bypass`. Bug OISF#5940
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Mar 28, 2023
As flow.memcap-policy and defrag.memcap-policy do not support flow actions, clarify that in the documentation. Also fix some typos, and add missing values in some places where the exception policies were explained. Related to Bug OISF#5940
jufajardini
added a commit
to jufajardini/suricata
that referenced
this pull request
Mar 29, 2023
Defrag memcap and flow memcap do not support flow action for the exception policies, as there is no flow when the exception condition is hit. In such cases, the exception policy must be considered for the packet only, when that makes sense, or should be ignored, in case of `bypass`. Bug OISF#5940 (cherry picked from commit d4333fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5939
Batch backports to 5.0.x
Describe changes:
Updates
#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: