Next/20210305/v3 #5958
Merged
Next/20210305/v3 #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5958 +/- ##
==========================================
+ Coverage 76.74% 76.75% +0.01%
==========================================
Files 604 604
Lines 187904 187853 -51
==========================================
- Hits 144213 144195 -18
+ Misses 43691 43658 -33
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
Mar 30, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 3, 2023
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 3, 2023
BPF codebase queried engine mode earlier than it was determined from the configuration file/command line. As a result it used the default (IDS) mode where it could've been configured later on to the IPS mode. This could lead into an undefined behavior as some Suricata modules behave according to the engine mode. PF-Ring, Netmap and AF-Packet all shared almost identical code for determining the engine mode. It was put into one common function. Omitted the usage of SCStrdup function in PF-Ring module as it is uppercased during thread initialization phase. Ticket: OISF#5958
lukashino
pushed a commit
to lukashino/suricata
that referenced
this pull request
May 3, 2023
Move evaluation of engine runmode to an earlier phase so that dependend modules rely on properly configured engine runmode. Ticket: OISF#5958
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
May 4, 2023
BPF codebase queried engine mode earlier than it was determined from the configuration file/command line. As a result it used the default (IDS) mode where it could've been configured later on to the IPS mode. This could lead into an undefined behavior as some Suricata modules behave according to the engine mode. PF-Ring, Netmap and AF-Packet all shared almost identical code for determining the engine mode. It was put into one common function. Omitted the usage of SCStrdup function in PF-Ring module as it is uppercased during thread initialization phase. Ticket: OISF#5958
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
May 4, 2023
Move evaluation of engine runmode to an earlier phase so that dependend modules rely on properly configured engine runmode. Ticket: OISF#5958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5957 with formatting fixes