-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next/20210525/v6 #6139
Merged
Merged
Next/20210525/v6 #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering parsers in Rust requires signatures to be a certain way and compatible with C. Change signatures of all the functions.
Get rid of the C glue code and move registration completely to Rust.
Registering parsers in Rust requires signatures to be a certain way and compatible with C. Change signatures of all the functions.
Get rid of the C glue code and move registration completely to Rust.
instead of deprecated add_stylesheet
This commit modifies the constructors to use Self and/or Default::default() when feasible
Including the whole directory results in .deps files ending up in the distribution archive which shouldn't be there. Instead we have to list all the test sources individually.
That may not be the case in midstream/async configurations
Codecov Report
@@ Coverage Diff @@
## master #6139 +/- ##
==========================================
- Coverage 76.87% 76.87% -0.01%
==========================================
Files 613 611 -2
Lines 186344 186209 -135
==========================================
- Hits 143248 143139 -109
+ Misses 43096 43070 -26
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced May 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6136 #6135 #6131 #6127