Next/20210823/v10 #6306
Merged
Next/20210823/v10 #6306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the flow manager would share evicted flows with the workers while keeping the flows mutex locked. This reduced the number of unlock/ lock cycles while there was guaranteed to be no contention. This turns out to be undefined behavior. A lock is supposed to be locked and unlocked from the same thread. It appears that FreeBSD is stricter on this than Linux. This patch addresses the issue by unlocking before handing a flow off to another thread, and locking again from the new thread. Issue was reported and largely analyzed by Bill Meeks. Bug: OISF#4478
As is done already in C cf commit ea09361
Ticket: OISF#4558 Avoids intra structure overflow
Ticket: OISF#4558 So as to avoid intra-structure overflow
So that CI does not fail, if suricata PR got upgraded in a new version, but S-V PR did not get upgraded, and S-V changed in master
Avoid spurious logs when suricatasc closes connection. Use SCLogDebug for control connection EOF, and SCLogError for an error. As Chandan Chowdhury described in redmine 3685. This makes the logging consistent with the older `if (client->version <= UNIX_PROTO_V1)` block about 20 lines above, and avoids polluting the logs with `Unix socket: lost connection with client`.
Codecov Report
@@ Coverage Diff @@
## master #6306 +/- ##
==========================================
- Coverage 76.97% 76.95% -0.03%
==========================================
Files 611 611
Lines 185941 185955 +14
==========================================
- Hits 143130 143102 -28
- Misses 42811 42853 +42
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Aug 23, 2021
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Sep 11, 2023
Ticket: OISF#6306 Keep a reference to last child, consume a bit more RAM to save CPU
victorjulien
pushed a commit
that referenced
this pull request
Oct 19, 2023
Ticket: #6306 Keep a reference to last child, consume a bit more RAM to save CPU
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Oct 27, 2023
Ticket: OISF#6306 Keep a reference to last child, consume a bit more RAM to save CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6301 with comment fixup
#6267
#6258
#6214
#5647