detect: debug validation for list ids overflows

[catenacyber]

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4403

Describe changes:

• Adds debug validation for list id integer overflow

975062c#diff-99eda33658bd0778da7bf89acbb4e7bbdb9ce82b0ab93486e1643691925f4091L600 has changed sm_list from int to int16_t
But there are no checks against integer overflow on this shorter integer

[codecov]

Codecov Report

Merging #6316 (eb077ae) into master (7551247) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6316      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.01%     
==========================================
  Files         611      611              
  Lines      185955   185955              
==========================================
- Hits       143102   143085      -17     
- Misses      42853    42870      +17     

Flag	Coverage Δ
fuzzcorpus	52.87% <ø> (+0.01%)	⬆️
suricata-verify	51.09% <ø> (-0.03%)	⬇️
unittests	63.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[suricata-qa]

Information: QA ran without warnings.

Pipeline 3960

[catenacyber]

And after a long quadratic time, I get the debug assert to trigger...
Let's see if oss-fuzz is getting it the same way

[victorjulien]

The id increases with the number of rules using unique combinations of transactions, I think. Is that what you're seeing?

[victorjulien]

Merged in #6324, thanks!

[catenacyber]

Let's now wait for google/oss-fuzz#6362 to get oss-fuzz back to build latest suricata and see if this is the bug getting triggered

[catenacyber]

The id increases with the number of rules using unique combinations of transactions, I think. Is that what you're seeing?

The unique combination of transforms ...
That is indeed what I am seeing (with the script from the redline ticket to generate 65k rules with different combinations of transforms)
Maybe there is another way to increase this id...