app-layer: disable by default if not in configuration #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNP3, ENIP, HTTP2 and Modbus are supposed to be disabled by default. That means the default configuration does it, but that also means that, if they are not in suricata.yaml, the protocol should stay disabled.
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
|
The S-V failure for modbus seems to prove this point |
|
WARNING:
Pipeline 4472 |
Codecov Report
@@ Coverage Diff @@
## master #6454 +/- ##
==========================================
- Coverage 76.98% 76.94% -0.04%
==========================================
Files 613 613
Lines 186712 186720 +8
==========================================
- Hits 143735 143681 -54
- Misses 42977 43039 +62
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
|
Merged in #6464 |
thomasjwinter
added a commit
to thomasjwinter/suricata
that referenced
this pull request
Nov 8, 2023
The hot reload results in large chunks of memory being freed as the as the old signature tables are discarded. Help the memory management system along by telling to release as much memory as it can at this point. Bug: OISF#6454.
3 tasks
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Nov 19, 2023
The hot reload results in large chunks of memory being freed as the as the old signature tables are discarded. Help the memory management system along by telling to release as much memory as it can at this point. Bug: OISF#6454.
inashivb
pushed a commit
to inashivb/suricata
that referenced
this pull request
Nov 22, 2023
The hot reload results in large chunks of memory being freed as the as the old signature tables are discarded. Help the memory management system along by telling to release as much memory as it can at this point. Bug: OISF#6454.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4739
Describe changes:
That means disable them when they are not in the configuration file
suricata-verify-pr: 553
OISF/suricata-verify#553