ftp: do not set alproto if one was already found #6651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 4857 If a pattern such as GET is seen ine the beginning of the file transferred over ftp-data, this flow will get recognized as HTTP, and a HTTP state will be created during parsing. Thus, we cannot override directly alproto's values This solves the segfault, but not the logical bug that the flow should be classified as FTP-DATA instead of HTTP
Codecov Report
@@ Coverage Diff @@
## master #6651 +/- ##
==========================================
+ Coverage 77.19% 77.24% +0.04%
==========================================
Files 613 613
Lines 185646 185648 +2
==========================================
+ Hits 143310 143398 +88
+ Misses 42336 42250 -86
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: QA failed on tlpw2_single_alerts_cmp. Pipeline 5097 |
1 major deviations in alert counts Looks like it happens regularly... |
Merged
|
Merged in #6705, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4857
Describe changes:
Does not solve the fact that the flow should have been detected as FTP-DATA in the first place