Packet alerts/v6 #6943
Closed
Packet alerts/v6 #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some unittests used SCMalloc for allocating new Packet the unittests. While this is valid, it leads to segmentation faults when we move to dynamic allocation of the maximum alerts allowed to be triggered by a single packet. This massive patch uses PacketGetFromAlloc, which initializes a Packet in such a way that any dynamic allocated structures within will also be initialized. Related to Task OISF#4207
The maximum of possible alerts triggered by a unique packet was hardcoded to 15. With usage of 'noalert' rules, that limit could be reached somewhat easily. Make that configurable via suricata.yaml. Conf Bug#4941 Task OISF#4207
Plus small clang formatting change.
Closed
Codecov Report
@@ Coverage Diff @@
## master #6943 +/- ##
==========================================
- Coverage 77.74% 77.73% -0.02%
==========================================
Files 628 628
Lines 185648 185547 -101
==========================================
- Hits 144332 144234 -98
+ Misses 41316 41313 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 6144 |
|
I think this looks good, but we still need to look at the feedback on my patch that Philippe pointed out in #6896 |
Okey dokey, should I try to address those as well? |
Closed
|
replaced by #6999 |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Apr 12, 2024
This is just another variant of DLT_RAW. Ticket: OISF#6943.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Apr 13, 2024
This is just another variant of DLT_RAW. Ticket: OISF#6943.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Apr 13, 2024
This is just another variant of DLT_RAW. Ticket: OISF#6943.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #6931
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4207
Describe changes:
BUG_ONcheck with config value checks and warning, falling back to defaultssuricata-verify-pr: 694