Next/20220208/v2 #6956
Merged
Next/20220208/v2 #6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
victorjulien
commented
Feb 8, 2022
•
victorjulien
commented
- detect-bytetest/v1: remove unittests #6945
- Feat/frames/v98 #6947
UDP frames point to the UDP packet payloads. The frames are removed after each packet. Ticket: OISF#4983.
Frames: - sip.pdu - sip.request_line - sip.response_line - sip.request_headers - sip.response_headers - sip.request_body - sip.response_body The `sip.pdu` frame is always created, the rest only if the record parser succeeded. Ticket: OISF#5036.
These tests are reimplemented as Suricata-Verify Task: 4911
Codecov Report
@@ Coverage Diff @@
## master #6956 +/- ##
==========================================
- Coverage 77.74% 77.70% -0.05%
==========================================
Files 628 628
Lines 185648 185653 +5
==========================================
- Hits 144332 144255 -77
- Misses 41316 41398 +82
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 6161 |
3 tasks
glongo
added a commit
to glongo/suricata
that referenced
this pull request
Apr 13, 2024
PDU frames are now created prior to input parsing to ensure that their creation is independent of the parsing outcome. Additionally, a minor style change has been applied by rustfmt. Ticket OISF#6956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.