rust/ike: convert parser to nom7 functions and upgrade dependency #6963
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6963 +/- ##
==========================================
- Coverage 77.71% 77.68% -0.04%
==========================================
Files 628 628
Lines 185653 185656 +3
==========================================
- Hits 144289 144232 -57
- Misses 41364 41424 +60
Flags with carried forward coverage won't be shown. Click here to find out more. |
| reserved, | ||
| payload_length | ||
| }, | ||
| data: if let Some(_data) = payload_data { _data } else { b"" } |
There was a problem hiding this comment.
One could use unwrap_or_default() here as well, right?
There was a problem hiding this comment.
@chifflier do you want to address this or shall we stage for merge as is?
There was a problem hiding this comment.
This is indeed equivalent to unwrap_or_default(). I'd prefer to use the later (shorter and more idiomatic).
Do you want me to push a second commit on this PR, or resubmit?
There was a problem hiding this comment.
Sure! PR sent in #6969
|
Also looks good and passes suricata-verify tests for IKE. Also learned about |
|
replaced by #6969 |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4994
Describe changes:
ipsec-parser