Next/20220216/v3 #7013
Merged
Next/20220216/v3 #7013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To propagate jb_set_string_from_bytes() generator update. Bug: OISF#5080.
*** CID 1499365: (UNINIT)
/src/util-file-swf-decompression.c: 98 in FileSwfZlibDecompression()
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
97 inflateInit(&infstream);
>>> CID 1499365: (UNINIT)
>>> Using uninitialized value "infstream.total_out" when calling "inflate".
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
103 break;
/src/util-file-swf-decompression.c: 98 in FileSwfZlibDecompression()
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
97 inflateInit(&infstream);
>>> CID 1499365: (UNINIT)
>>> Using uninitialized value "infstream.total_out" when calling "inflate".
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
103 break;
*** CID 1499363: Error handling issues (CHECKED_RETURN)
/src/util-file-swf-decompression.c: 97 in FileSwfZlibDecompression()
91
92 infstream.avail_in = (uInt)compressed_data_len;
93 infstream.next_in = (Bytef *)compressed_data;
94 infstream.avail_out = (uInt)decompressed_data_len;
95 infstream.next_out = (Bytef *)decompressed_data;
96
>>> CID 1499363: Error handling issues (CHECKED_RETURN)
>>> Calling "inflateInit_(&infstream, "1.2.11", 112)" without checking return value. This library function may fail and return an error code.
97 inflateInit(&infstream);
98 int result = inflate(&infstream, Z_NO_FLUSH);
99 switch(result) {
100 case Z_STREAM_END:
101 break;
102 case Z_OK:
Bug: OISF#5079.
so as to avoid performance problems coming from this.
When we want to share our code in our documentation pages, the current rust formatting isn't so nice to read. Formatted just the portion of the code that will be shown, for now.
Our current rust code isn't always documentation friendly when it comes to using code snippets. Used rustfmt to apply rust default formatting on functions that we wanted to show in our documentation for Frame support
With these, the portion of code within the tags should be included in the related code-snippets (for frame support documentation) w/o errors, even if the code within changes. The tags can also work as a reminder that the existing code is being shown elsewhere, so folks know documentation might need updates, in case of major changes.
With these, the portion of code within the tags should be included in the related code-snippets (for frame support documentation) w/o errors, even if the code within changes. The tags can also work as a reminder that the existing code is being shown elsewhere, so folks know documentation might need updates, in case of major changes.
This explains the frame support from the perspective of a developer, with introductory explanation on how to add frame support to an applayer proto. Doc OISF#4697
|
Additionally a minor update to runmodes doc, which obsoletes #5945 |
Codecov Report
@@ Coverage Diff @@
## master #7013 +/- ##
==========================================
- Coverage 77.68% 77.62% -0.06%
==========================================
Files 628 628
Lines 185657 185632 -25
==========================================
- Hits 144232 144104 -128
- Misses 41425 41528 +103
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Feb 16, 2022
|
Information: QA ran without warnings. Pipeline 6290 |
This was referenced Feb 17, 2022
Closed
Closed
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: