Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: only apply ConfigApplyTx with app-layers #7015

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4972

Describe changes:

  • detect: only apply ConfigApplyTx with app-layers

If the scope is flow it should require a flow to be present.

How do we do that ?
I do not see SIG_FLAG_FLOW

Ticket: 4972

Otherwise, it makes no sense to look for a tx...
@catenacyber catenacyber requested a review from a team as a code owner February 17, 2022 12:31
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #7015 (9c596ec) into master (e04fcfc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7015      +/-   ##
==========================================
- Coverage   77.69%   77.65%   -0.04%     
==========================================
  Files         628      628              
  Lines      185635   185637       +2     
==========================================
- Hits       144221   144149      -72     
- Misses      41414    41488      +74     
Flag Coverage Δ
fuzzcorpus 58.04% <100.00%> (-0.32%) ⬇️
suricata-verify 54.45% <100.00%> (+0.02%) ⬆️
unittests 63.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

I think the SIG_MASK_REQUIRE_FLOW can be of use here. You may need to dig around a bit to see how you can trigger it getting set.

@victorjulien
Copy link
Member

I think the SIG_MASK_REQUIRE_FLOW can be of use here. You may need to dig around a bit to see how you can trigger it getting set.

Or how it is set in other places for inspiration.

@catenacyber
Copy link
Contributor Author

Thanks Victor, done in #7063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants