Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: handle undefined LEVEL1_DCACHE_LINESIZE #7350

Closed
wants to merge 1 commit into from

Conversation

satta
Copy link
Contributor

@satta satta commented Apr 30, 2022

Describe changes:

  • On some platforms (riscv64, s390x) this value is undefined as returned from getconf. We also need to handle this to avoid using the string undefined blindly in further #defines, which would otherwise cause compile errors.

On some platforms (riscv64, s390x) this value is "undefined" as returned
from getconf. We also need to handle this to avoid using the string
"undefined" blindly in further #defines.
@satta satta requested a review from a team as a code owner April 30, 2022 12:23
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #7350 (84b39ed) into master (07d0ae0) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7350      +/-   ##
==========================================
- Coverage   75.87%   75.78%   -0.10%     
==========================================
  Files         656      656              
  Lines      190056   190052       -4     
==========================================
- Hits       144211   144028     -183     
- Misses      45845    46024     +179     
Flag Coverage Δ
fuzzcorpus 60.35% <ø> (-0.19%) ⬇️
suricata-verify 51.73% <ø> (+0.11%) ⬆️
unittests 61.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the commit title is not clear, but the code is good to get Suricata to compile on some systems

@victorjulien
Copy link
Member

Merged in #7367, thanks Sascha!

@satta satta deleted the cls-undefined branch May 4, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants