Smb dcerpc logging #7584
Closed
Smb dcerpc logging #7584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As context id is used to know to which variant of the endpoint the request is done, it is interesting to parse it. Feature OISF#5413.
When doing a DCERPC request, we can use the context id to log the interface that is used. Doing that we can see in one single event what is the DCERPC interface and opnum that are used. This allows to have all the information needed to resolve the request to a function call. Feature OISF#5413.
| if i.context_id == x.context_id { | ||
| jsb.open_object("interface")?; | ||
| let ifstr = uuid::Uuid::from_slice(&i.uuid); | ||
| let ifstr = ifstr.map(|ifstr| ifstr.to_hyphenated().to_string()).unwrap(); |
There was a problem hiding this comment.
I need to check but I did reuse the code that is used to log DCERPC list of interfaces (in bind operation).
There was a problem hiding this comment.
Ok I see this is a common pattern indeed.
Codecov Report
@@ Coverage Diff @@
## master #7584 +/- ##
==========================================
- Coverage 75.80% 75.74% -0.07%
==========================================
Files 658 658
Lines 186526 186523 -3
==========================================
- Hits 141399 141283 -116
- Misses 45127 45240 +113
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on ips_afp_drop_chk. Pipeline 8024 |
victorjulien
approved these changes
Aug 25, 2022
This was referenced Aug 25, 2022
Merged
Closed
Merged
|
Merged in #7774, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5413
Describe changes: