Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: transforms check for 0-sized buffer #7770

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5521

Describe changes:

  • transforms check for 0-sized buffer to avoid undefined behavior with a 0-sized variable length array

So as to avoid undefined behavior with a 0-sized variable length
array

Ticket: OISF#5521
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #7770 (bdd7d32) into master (9353b07) will increase coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #7770      +/-   ##
==========================================
+ Coverage   75.98%   76.04%   +0.06%     
==========================================
  Files         661      661              
  Lines      185764   185773       +9     
==========================================
+ Hits       141152   141274     +122     
+ Misses      44612    44499     -113     
Flag Coverage Δ
fuzzcorpus 60.96% <50.00%> (+0.13%) ⬆️
suricata-verify 52.51% <50.00%> (-0.01%) ⬇️
unittests 60.70% <37.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

This was referenced Aug 25, 2022
@suricata-qa
Copy link

Information:

ERROR: QA failed on ips_afp_drop_chk.

field test baseline %
ips_afp_stats_chk
.flow.end.state.new 89454 10800 828.28%
.flow.end.tcp_liberal 249993 108000 231.48%
.tcp.reassembly_gap 794092 108000 735.27%
.app_layer.tx.ftp 248753 263520 94.4%
.app_layer.tx.dcerpc_tcp 1003806 1101600 91.12%
generic_stats_chk
.capture.kernel_drops 4468569 5654519 79.03%
.flow.end.tcp_state.syn_sent 887 183 484.7%
.flow.end.tcp_state.syn_recv 37 52 71.15%
.tcp.segment_memcap_drop 5393 11729 45.98%
.tcp.insert_data_normal_fail 5216 11358 45.92%
.app_layer.error.smtp.gap 75 61 122.95%

Pipeline 8800
WARNING: THERE IS A KNOWN BAD BASELINE WITH PACKET DROPS. bE MINDFUL OF ANY RESULTS.

@victorjulien
Copy link
Member

Merged in #7774, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants