Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exceptions: error out when invalid policy is used (6.0.x backport) - v1 #7780

Closed
wants to merge 2 commits into from
Closed

exceptions: error out when invalid policy is used (6.0.x backport) - v1 #7780

wants to merge 2 commits into from

Conversation

jufajardini
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5525

Describe changes:

  • Exception policy error out in case of invalid value - 6.0.x backport
  • sphinx language setting fix - 6.0.x backport

jufajardini and others added 2 commits August 26, 2022 18:05
@jufajardini
exceptions: error out when invalid policy is used
38494a1 
Before, if an invalid value was passed as exception policy, Suricata
would log a warning and set the exception policy to "ignore". This is a
very different result, than, say, dropping or bypassing a midstream flow.

Task OISF#5504

(cherry picked from commit 58ef3cd)
@inashivb @jufajardini
doc/conf: fix sphinx language setting
103dfff 
sphinx-build 5.1.1 and above throws a warning which is treated as an
error while building.

Invalid configuration value found: 'language = None'. Update your configuration to a valid language code. Falling back to 'en' (English).

(cherry picked from commit 2c4d6b3)
@jufajardini jufajardini requested review from norg and a team as code owners August 26, 2022 21:27
@suricata-qa
Copy link

Information:

ERROR: QA failed on ips_afp_drop_chk.

field test baseline %
ips_afp_stats_chk
.decoder.udp 389692698 410851438 94.85%
.tcp.reassembly_gap 1216777 108000 1126.65%
.app_layer.flow.http 410075 434160 94.45%
.app_layer.flow.tls 920085 974152 94.45%
.app_layer.flow.failed_tcp 204388 218160 93.69%
.app_layer.tx.ftp 242111 263520 91.88%
.app_layer.tx.smtp 128092 149040 85.94%
.app_layer.tx.dcerpc_tcp 1002479 1101600 91.0%
generic_stats_chk
.capture.kernel_drops 1222 3018 40.49%

Pipeline 8820
WARNING: THERE IS A KNOWN BAD BASELINE WITH PACKET DROPS. bE MINDFUL OF ANY RESULTS.

@victorjulien victorjulien mentioned this pull request Sep 1, 2022
Merged
@victorjulien
Copy link
Member

Merged in #7806, thanks!

@jufajardini jufajardini deleted the 5504-backport-exception-policy-error-out/v1 branch September 5, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norg norg Awaiting requested review from norg norg is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@jufajardini @suricata-qa @victorjulien @inashivb