Bug/tls frag incomplete/v51 #7794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TLS record header is parsed in streaming mode still, but once the record size is known we tell the app-layer API to give us the full record. Ticket: OISF#5481
TCP Buffering is now done in the app-layer using the incomplete API, on the SSL/TLS record level. TLS level fragmentation will be implemented separately.
Implement TLS record defrag for handshake messages. Ticket: OISF#5183.
These tests are incompatible with the incomplete API usage and should have been pcap based tests in the first place.
Resolves RustSec issues in time and chrono: - https://rustsec.org/advisories/RUSTSEC-2020-0071 - https://rustsec.org/advisories/RUSTSEC-2020-0159 Ticket: OISF#5259. Ammended by Victor Julien to bump to 0.14 instead of 0.13.
Keep the more specific ones.
Don't set TLS_DECODER_EVENT_INVALID_HANDSHAKE_MESSAGE event on encrypted handshake messages.
In preparation for client cert handling.
Code cleanups that work on per direction "connp" instead of hard coding to the server side.
Parse client cerificates and store them in the state similar to how this is done for server certificates. Update "progress" handling to not consider the TLS handshake complete if the server indicated a client cert was needed.
Enable client logging in extended mode. Add "client", "client_certificate" and "client_chain", where the latter two depend on "client".
Cert chain is a list of pointers into this buffer, so can't use a stream slice approach.
Indirect dependency through x509-parser.
This was referenced Aug 30, 2022
|
replaced by #7796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7788 with some additional fixes.
Also adds a cert chain len keyword:
https://redmine.openinfosecfoundation.org/issues/5191
Tickets:
https://redmine.openinfosecfoundation.org/issues/5191
https://redmine.openinfosecfoundation.org/issues/1096
https://redmine.openinfosecfoundation.org/issues/5183
https://redmine.openinfosecfoundation.org/issues/5481
suricata-verify-pr: 911