Landlock v1.4 #7829
Closed
Landlock v1.4 #7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7829 +/- ##
==========================================
- Coverage 76.10% 75.99% -0.11%
==========================================
Files 663 664 +1
Lines 185889 185890 +1
==========================================
- Hits 141467 141275 -192
- Misses 44422 44615 +193
Flags with carried forward coverage won't be shown. Click here to find out more. |
This patch is adding support for Landlock, a Linux Security Module available since Linux 5.13. The concept is to prevent any file operation on directories where Suricata is not supposed to access. Landlock support is built by default if the header is present. The feature is disabled by default and need to be activated in the YAML to be active. Landlock documentation: https://docs.kernel.org/userspace-api/landlock.html Feature: OISF#5479
If landlock ABI is inferior to 2 (before Linux 5.19) then the renaming of files is impossible if the protection is enabled. This patch disables landlock if ABI < 2 and file-store is enabled. As file store is initialized in output the call to landlock had to done after the output initialization.
|
WARNING:
Pipeline 9018 |
|
Information: QA ran without warnings. Pipeline 9023 |
jufajardini
reviewed
Sep 8, 2022
victorjulien
reviewed
Sep 9, 2022
| @@ -1097,6 +1097,22 @@ asn1-max-frames: 256 | |||
| # user: suri | |||
| # group: suri | |||
|
|
|||
| security: | |||
| # Limit processus creation by Suricata (default: yes) | |||
Merged
|
Merged in #7853, thanks a lot for this work Eric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #7697
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5479
Describe changes: