Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix lint warnings about ptr_arg #8002

Closed
wants to merge 1 commit into from
Closed

rust: fix lint warnings about ptr_arg #8002

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2022

Ticket: #4599

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Previous pr: #7992

Describe changes:

  • Update commit message

@ghost ghost requested review from victorjulien and jasonish as code owners October 13, 2022 19:37
@ghost ghost mentioned this pull request Oct 13, 2022
3 tasks
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #8002 (5068144) into master (2158dbf) will decrease coverage by 0.07%.
The diff coverage is 93.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8002      +/-   ##
==========================================
- Coverage   81.65%   81.58%   -0.08%     
==========================================
  Files         953      953              
  Lines      275749   275749              
==========================================
- Hits       225158   224964     -194     
- Misses      50591    50785     +194     
Flag Coverage Δ
fuzzcorpus 63.30% <93.75%> (-0.09%) ⬇️
suricata-verify 58.90% <93.75%> (-0.03%) ⬇️
unittests 63.47% <31.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jasonish
Copy link
Member

Code looks good. But in commit messages we prefer to have your "Firstname Lastname " as the author, if you can fix that up.

@jufajardini
Copy link
Contributor

Code looks good. But in commit messages we prefer to have your "Firstname Lastname " as the author, if you can fix that up.

Hey @kmje can you look into this, so we can approve this PR for merge? :)

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 18, 2022
@ghost ghost closed this by deleting the head repository Oct 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
3 participants