Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-filename: convert unittests to FAIL/PASS APIs #8036

Closed

Conversation

AkakiAlice
Copy link
Contributor

Task: #4036

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4036

Describe changes:

  • Update detect-filename unit tests to use FAIL/PASS APIs.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #8036 (f56ea5e) into master (2158dbf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8036      +/-   ##
==========================================
- Coverage   81.65%   81.63%   -0.02%     
==========================================
  Files         953      953              
  Lines      275749   275744       -5     
==========================================
- Hits       225158   225112      -46     
- Misses      50591    50632      +41     
Flag Coverage Δ
fuzzcorpus 63.70% <ø> (+0.31%) ⬆️
suricata-verify 58.89% <ø> (-0.04%) ⬇️
unittests 63.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 19, 2022
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@victorjulien victorjulien mentioned this pull request Oct 24, 2022
@victorjulien
Copy link
Member

Merged in #8085, thanks!

@AkakiAlice AkakiAlice deleted the detect-filename-fail/pass-4036-v1 branch October 28, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
3 participants