detect-icmp-seq: convert unittests to FAIL/PASS APIs

[AkakiAlice]

Task: #4043

Make sure these boxes are signed before submitting your Pull Request -- thank you.

• I have read the contributing guide lines at https://redmine.openinfosecfoundation.org/projects/suricata/wiki/Contributing
• I have signed the Open Information Security Foundation contribution agreement at https://suricata.io/about/contribution-agreement/
• I have updated the user guide (in doc/userguide/) to reflect the changes made (if applicable)

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4043

Previous PR: #8080

Describe changes:

• Update detect-icmp-seq to use FAIL/PASS API

[codecov]

Codecov Report

Merging #8089 (18c68a7) into master (2158dbf) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8089      +/-   ##
==========================================
+ Coverage   81.65%   81.71%   +0.05%     
==========================================
  Files         953      954       +1     
  Lines      275749   275707      -42     
==========================================
+ Hits       225158   225283     +125     
+ Misses      50591    50424     -167     

Flag	Coverage Δ
fuzzcorpus	63.76% <ø> (+0.38%)	⬆️
suricata-verify	59.19% <ø> (+0.26%)	⬆️
unittests	63.50% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jufajardini]

Changes look good to me, thanks :)

After OISF/suricata-verify#980 gets merged, you can then proceed to remove the converted unittest.

[victorjulien]

Merged in #8097, thanks for your contribution!