snmp: log response values #8158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
commented
Nov 8, 2022
| // Request has empty, do not log it | ||
| ObjectSyntax::Empty => {} | ||
| _ => { | ||
| pdu_info.vals.push(format!("{:?}", var.val)); |
There was a problem hiding this comment.
Do we want to log everything this way ?
|
WARNING:
Pipeline 10491 |
catenacyber
force-pushed
the
snmp-values-5653-v1
branch
from
cb0a676
to
f6323ca
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8158 +/- ##
==========================================
+ Coverage 81.73% 81.81% +0.08%
==========================================
Files 962 962
Lines 276975 276985 +10
==========================================
+ Hits 226379 226623 +244
+ Misses 50596 50362 -234
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 10605 |
|
not wanted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5653
Describe changes:
Do we want to have a config option for this ?