detect/cert: Use client side certs #8298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 5516 This commit modifies the detect logic to choose the certificate based on the flow direction -- to server or to client.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8298 +/- ##
==========================================
- Coverage 81.75% 81.67% -0.08%
==========================================
Files 963 963
Lines 277737 277788 +51
==========================================
- Hits 227051 226877 -174
- Misses 50686 50911 +225
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 11247 |
|
Have you been able to find a pcap for some SV tests? |
|
I haven't been able to :-( |
Merged
|
Merged in #8314, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 5516
This commit modifies the detect logic to choose the certificate based on the flow direction -- to server or to client.
Link to redmine ticket: 5516
Describe changes:
#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: