output/eve: add 'verdict' field to 'alert' and 'drop' events - v2 #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eve logs have a field alert.action that will say something like 'allowed' even if a packet gets blocked by some other rule. To make this less ambiguous, added a field to the alert and drop events indicating the final verdict by the engine for a given packet. Bug OISF#5464
The `field action` portion seemed to be comprised of a more generic section that followed it. Also formatted the section for lines to be within the character limit.
This field has caused confusion when packets or flows match on rules with different actions, therefore resulting in conflicting 'action' logged out. Make this optional after the inclusion of the [final] 'verdict' field, which indicates the actual action performed. Bug OISF#5464
|
WARNING:
Pipeline 11389 |
|
Replaced by #8348 as this has an error in the global variable name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5464
Previous PR: #8318
Changes from last PR:
actionfield optionalverdictfield as a mandatory field foralertanddropeventsverdictentry in theoutputssection to list actually logged valuesdropeventalerteve sectionsuricata-verify-pr: 1057
OISF/suricata-verify#1057