Pr 8341 and payload len fix/v2 #8393
Closed
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the packet is shorter than IP payload length we no longer flag it as an invalid UDP packet. UDP packet can be therefore shorter than IP payload. Redmine ticket: OISF#5693
Fix payload_len calculation post removal of the condition that returned error code if the length to the decode fn did not match the length of header from the UDP packet. Bug 5379
inashivb
force-pushed
the
pr-8341-and-payload-len-fix/v2
branch
from
db79144
to
28a2c70
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8393 +/- ##
==========================================
- Coverage 81.94% 81.93% -0.02%
==========================================
Files 963 963
Lines 277683 277686 +3
==========================================
- Hits 227561 227530 -31
- Misses 50122 50156 +34
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 11673 |
|
WARNING:
Pipeline 11677 |
victorjulien
requested changes
Jan 18, 2023
| @@ -160,6 +160,9 @@ static DetectEngineEventData *DetectEngineEventParse (const char *rawstr) | |||
|
|
|||
| if (de->event == STREAM_REASSEMBLY_OVERLAP_DIFFERENT_DATA) { | |||
| StreamTcpReassembleConfigEnableOverlapCheck(); | |||
| } else if (de->event == UDP_HLEN_INVALID) { | |||
There was a problem hiding this comment.
I think this should be implemented using the strict concept as done here: https://github.com/OISF/suricata/blob/master/src/detect-app-layer-event.c#L201
cc @lukashino
There was a problem hiding this comment.
@jufajardini this strict concept should make it to the dev guide :)
There was a problem hiding this comment.
followed the concept and created OutdatedEvent function in decode part of the engine.
|
replaced by #8404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/5379
https://redmine.openinfosecfoundation.org/issues/5693
Previous PR: #8342
Changes since v1:
suricata-verify-pr: 1055