Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftp: completely resets port_line (backport6) #8395

Closed
wants to merge 1 commit into from
Closed

ftp: completely resets port_line (backport6) #8395

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5804

Describe changes:

Clean cherry-pick

@catenacyber
ftp: completely resets port_line
2fde3a2 
In the case port_line is first allocated and port_line_len is set,
Then a second request reaches memcap and frees port_line,
port_line_len should also be reset, because both will get used
by the response parsing.

Ticket: OISF#5701
(cherry picked from commit 1660172)
@catenacyber catenacyber requested a review from a team as a code owner January 18, 2023 08:57
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
TREX_GENERIC_stats_chk
.capture.kernel_drops 0 3963 0.00

Pipeline 11681

@catenacyber
Copy link
Contributor Author

CI : SSL certificate problem: certificate has expired for Nmap.org

This was referenced Jan 23, 2023
Closed
Merged
@victorjulien
Copy link
Member

Merged in #8428, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@catenacyber @suricata-qa @victorjulien