Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smb/ntlmssp: parse fields independently of order (backport-6.0.x) #8431

Closed
wants to merge 1 commit into from
Closed

smb/ntlmssp: parse fields independently of order (backport-6.0.x) #8431

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5810

Describe changes:

Not a clean cherry-pick because of nom vs nom7

I took only the first commit (not the rustfmt, neither the event one)

@catenacyber
smb/ntlmssp: parse fields independently of order
a94bcb5 
Instead of relying on the usual ordering...

Ticket: OISF#5258
(cherry picked from commit 1db8685)

Manual conflict fixes to use nom instead of nom7
@victorjulien victorjulien mentioned this pull request Jan 25, 2023
Merged
@victorjulien
Copy link
Member

Merged in #8458, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@catenacyber @victorjulien