log: Stop if log initialization fails at startup #8538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 5836 This commit modifies Suricata to fail if log initialization errors occur during startup.
Issue: 5836 This commit removes the duplicate threaded file tracking from the log file mechanisms. Tracking is now consolidated with the threaded hash table.
|
Information: QA ran without warnings. Pipeline 12388 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8538 +/- ##
==========================================
- Coverage 81.95% 78.47% -3.48%
==========================================
Files 967 967
Lines 278373 278139 -234
==========================================
- Hits 228129 218266 -9863
- Misses 50244 59873 +9629
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Closing to handle shutdown case with log rotation and plugin. |
|
Continued in #8544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8519
Issue: 5836
This commit modifies Suricata to fail if log initialization errors occur during startup.
Link to redmine ticket: 5836
Describe changes:
Updates
suricata-verify-pr: 1114
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: