Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netmap: packet stalls (6.0.x backport) #5863 v1 #8549

Closed

Conversation

bmeeks8
Copy link
Contributor

@bmeeks8 bmeeks8 commented Feb 21, 2023

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5863

Describe changes:

  • Fix packet processing stall under high load when using netmap in IPS mode (see Redmine #5863 and related issue #5744).
  • Detect and generate FatalError() exit for the rare case when hardware NICs expose unmatched RX/TX queue counts (for example, exposing more TX queues than RX queues). This is a rare possibility, but if not detected and handled it would result in some netmap traffic bypassing Suricata since the code previously assumed NIC queue counts were always symmetrical.
  • Fix instance of missing unlock calls for the netmap device list when exiting a function due to an error condition.
  • Clean up and/or add some comments to more accurately reflect what's happening in the new netmap code.

@bmeeks8 bmeeks8 requested a review from a team as a code owner February 21, 2023 15:37
@bmeeks8
Copy link
Contributor Author

bmeeks8 commented Feb 22, 2023

Replaced by #8551.

@bmeeks8 bmeeks8 closed this Feb 22, 2023
@bmeeks8 bmeeks8 deleted the netmap_stall_fix_6.0.x_backport branch February 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant