Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtp: sync in-code defaults with configuration file - v1 #8599

Closed
wants to merge 3 commits into from

Conversation

jasonish
Copy link
Member

Currently the default suricata.yaml sets some values that do not
reflect the default values in the code. As most users are probably
using a default suricata.yaml, make the code have the same defaults as
in suricata.yaml:

  • mime.decode-mime: false -> true
  • mime.decode-base64: false -> true
  • mime.decode-quoted-printable: false -> true
  • mime.extract-urls: false -> true

I guess the question is if its OK for a simple configuration of:

app-layer:
  protocols:
    smtp:
      enabled: yes

to acquire these new defaults.

Ticket: https://redmine.openinfosecfoundation.org/issues/5823

Currently the default suricata.yaml sets some values that do not
reflect the default values in the code. As most users are probably
using a default suricata.yaml, make the code have the same defaults as
in suricata.yaml:

- mime.decode-mime: false -> true
- mime.decode-base64: false -> true
- mime.decode-quoted-printable: false -> true
- mime.extract-urls: false -> true

Issue: OISF#5823
@jasonish jasonish changed the title smtp: sync in-code defaults with configuratil file - v1 smtp: sync in-code defaults with configuration file - v1 Mar 15, 2023
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW1_stats_chk
.flow.end.tcp_state.last_ack 1004 257 25.6%
SURI_TLPR1_stats_chk
.flow.end.tcp_state.fin_wait2 156072 127814 81.89%

Pipeline 12751

@victorjulien victorjulien mentioned this pull request Mar 17, 2023
@victorjulien
Copy link
Member

Merged in #8605, thanks!

@jasonish jasonish deleted the smtp-defaults/v1 branch November 14, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants