http: complete multipart until request.body-limit #8641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case we are truncating a multipart file because of reaching request.body-limit, we used to not consume the whole buffer, but keep expected_boundary_len bytes in case a new boundary begins in these bytes. Even if we cannot check the complete boundary, we can still check the first bytes, as will be done in the rust version. Ticket: OISF#5952
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8641 +/- ##
==========================================
- Coverage 81.94% 81.93% -0.01%
==========================================
Files 968 968
Lines 278837 278842 +5
==========================================
- Hits 228488 228483 -5
- Misses 50349 50359 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 12879 |
|
Merged after rebase in #8648, thanks! |
|
Was SURI_TLPW1_files_sha256 updated after this merge ? |
This was referenced Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5952
This illustrates the QA SURI_TLPW1_files_sha256 differences from #8450
#8450 is right for hash 0adad78526c1b9c35f349a2cc7014c458aa87adcb9ec86f052fd8a9a80584e39 and master is wrong because being zealous with the limit
request.body_limitand taking less bytes than it canI propose we merge this first, do the QA rebase, and then rebase #8450 to check SURI_TLPW1_files_sha256 again
Replaces #8510 with rebase and commit reword with redmine ticket reference
suricata-verify-pr: 1109
OISF/suricata-verify#1109