Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netmap: Forward port packet stall fix #8666

Closed
wants to merge 1 commit into from
Closed

Conversation

jlucovsky
Copy link
Contributor

Issue: 5862

This commit forward ports fixes from master-6.0.x that address packet stalling that may occur under IPS configurations.

Describe changes:

#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch:

Issue: 5862

This commit forward ports fixes from master-6.0.x that address packet
stalling that may occur under IPS configurations.
@jlucovsky
Copy link
Contributor Author

@bmeeks8 These represent the changes needed for the stalling issue for the new netmap API only. Could you review?

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #8666 (d565711) into master (578f328) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8666      +/-   ##
==========================================
- Coverage   81.92%   81.80%   -0.13%     
==========================================
  Files         968      968              
  Lines      278942   279008      +66     
==========================================
- Hits       228516   228235     -281     
- Misses      50426    50773     +347     
Flag Coverage Δ
fuzzcorpus 64.04% <ø> (-0.41%) ⬇️
suricata-verify 59.80% <ø> (+0.02%) ⬆️
unittests 63.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 12960

@bmeeks8
Copy link
Contributor

bmeeks8 commented Apr 2, 2023

@bmeeks8 These represent the changes needed for the stalling issue for the new netmap API only. Could you review?

I have reviewed the changes and see no problems.

@jlucovsky
Copy link
Contributor Author

@bmeeks8 These represent the changes needed for the stalling issue for the new netmap API only. Could you review?

I have reviewed the changes and see no problems.

Thanks @bmeeks8 !

@victorjulien victorjulien mentioned this pull request Apr 3, 2023
@victorjulien
Copy link
Member

Merged in #8677, thanks!

@jlucovsky jlucovsky deleted the 5862/1 branch April 16, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants