Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smb/ntlmssp: fix parsing of negotiate flags #8673

Closed
wants to merge 1 commit into from
Closed

smb/ntlmssp: fix parsing of negotiate flags #8673

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5783

Describe changes:

  • smb/ntlmssp: fix parsing of negotiate flags

Ie get the right bit

Follows on #8585 with removing use of confusing bits parser

@catenacyber catenacyber mentioned this pull request Apr 3, 2023
Closed
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 12988

jasonish
jasonish approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems correct when compared against Wireshark and the provided SMB documentation.

However, given it has no affect on the output that I can see, I'm still curious how this bug was noticed, and what the user impact would be.

@catenacyber catenacyber mentioned this pull request May 4, 2023
Closed
@catenacyber
Copy link
Contributor Author

However, given it has no affect on the output that I can see, I'm still curious how this bug was noticed, and what the user impact would be.

See OISF/suricata-verify#1192

@victorjulien victorjulien mentioned this pull request May 5, 2023
Merged
@victorjulien
Copy link
Member

Merged in #8815, thanks!

@catenacyber catenacyber mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@catenacyber @suricata-qa @victorjulien @jasonish