Multipart mime http complete backport6 v1 #8686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah lets squash them. |
In the case we are truncating a multipart file because of reaching request.body-limit, we used to not consume the whole buffer, but keep expected_boundary_len bytes in case a new boundary begins in these bytes. Even if we cannot check the complete boundary, we can still check the first bytes, as will be done in the rust version. Ticket: OISF#5952 (cherry picked from commit 578f328) (cherry picked from commit caf9940)
catenacyber
force-pushed
the
multipart-mime-http-complete-backport6-v1
branch
from
af4055e
to
92fdb67
Compare
Done and force-pushed, do you want a new PR ? |
|
ERROR: ERROR: QA failed on SURI_TLPW1_files_sha256. Pipeline 13031 |
|
ERROR: ERROR: QA failed on SURI_TLPW1_files_sha256. Pipeline 13034 |
Merged
|
Merged in #8690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5953
Describe changes:
Should I squash the commits together or keep the cherry-picks even if it introduces a buggy commit ?