config: document includes #8915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 7.0 multiple includes are allowed, but marked as deprecated. Update the example to show the new way of pulling in multiple includes.
Two "Logging changes" sections existed, merge.
Document how to use include files, plus add a deprecation notice on the use of multiple "include" statements.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8915 +/- ##
==========================================
+ Coverage 82.30% 82.34% +0.03%
==========================================
Files 969 969
Lines 273335 273335
==========================================
+ Hits 224961 225070 +109
+ Misses 48374 48265 -109
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced May 30, 2023
Closed
Closed
Merged
|
Merged in #8945, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the new style includes as well as the deprecation of multiple
includestatements.The actual was done and merged as part of
#8632, but documentation was
missing, mainly because includes aren't well documented.
Ticket: https://redmine.openinfosecfoundation.org/issues/5939