decode-ipv6: Set IPv6 proto incase of ext header parsing error #8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the IPv6 packet proto before parsing the ext headers, similar to decode-ipv4, incase of an ext header parsing error. Otherwise rule decode-events are not triggered for packets encapsulated in IPv6. Bug: OISF#6086.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8917 +/- ##
==========================================
+ Coverage 82.30% 82.35% +0.04%
==========================================
Files 969 969
Lines 273335 273336 +1
==========================================
+ Hits 224961 225094 +133
+ Misses 48374 48242 -132
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Thanks for this @coledishington What happens if we have 4 bytes of UDP header (instead of 0) ? Should (or do we already) have another decode event when a layer is missing ? |
|
@catenacyber A partial UDP header triggers the same decode-event failures. For my use case, the difference between a partial (4B) UDP header and zero byte UDP header is not significant. Thanks |
|
Thanks, could you open a new rebased Pull Request in Suricata with the reference to the new S-V PR ? |
|
@catenacyber Created new pull request #8979. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the IPv6 packet proto before parsing the ext headers, similar to decode-ipv4, incase of an ext header parsing error. Otherwise rule decode-events are not triggered for packets encapsulated in IPv6.
Bug: #6086.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6086
Link to suricata-verify test case:
OISF/suricata-verify#1218
Describe changes:
Set the IPv6 packet proto before parsing the ext headers, similar to decode-ipv4, incase of an ext header parsing error.
SV_BRANCH=pr/1218