Fix midstream exception policy bug 5825 - v3 #8952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated FlowGetNew documentation, where it said NULL was only returned in case of error.
The different interactions between midstream pick-up sessions and the exception policy can be quite difficult to visualize. Add a section for that in the userguide. Related to Bug OISF#5825
Some exception policies can only be applied to the triggering packet or only make sense considering the whole flow. Highlight such cases in the table showing each exception policy. Related to Bug OISF#5825
Split up ExceptionPolicyParse to try to improve readability. Related to Bug OISF#5825
As the midstream exception policy has its own specific scenarios, have a dedicated function to parse and process its config values, and check for midstream enabled when needed. Related to Bug OISF#5825
Get the enum values from the config file. Update the new extracted functions. Post-process the config values based on runmode and policy. Also handle 'auto' enum value in these. Related to Bug OISF#5825
As the SCLogConfig output isn't showing, ensure that we use a log level more likely to be seen by users, if need be. Related to Bug OISF#5825
We were always setting it to ignore, due to bug 5825.
The engine will now issue an initialization error if an invalid value
is passed in the configuration file for midstream exception policy.
'pass-packet' or 'drop-packet' are never valid, as the midstream policy
concerns the whole flow, not making sense for just a packet.
If midstream is enabled, only two actual config values are allowed:
'ignore' and 'pass-flow', both in IDS and in IPS mode. In default mode
('auto' or if no policy is defined), midstream-policy is set to
'ignore'. All other values will lead to initialization error.
In IDS mode, 'drop-flow' will also lead to initialization error.
Part of
Bug OISF#5825
This is no longer valid for midstream exception policies. Part of Bug OISF#5825
This was referenced Jun 2, 2023
|
Information:
Pipeline 14207 |
|
seems to fail due to https://redmine.openinfosecfoundation.org/issues/6109 |
|
Replaced by: #8969 - which uses SV PR without 6109 test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5825
Previous (draf) PR: #8948
Describe changes:
SV_BRANCH=pr/1226
OISF/suricata-verify#1226