Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/byte-math: Support multiplication operator #9010

Closed
wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Jun 12, 2023

Issue: 6070

This commit adds support for the multiplication operator to byte-math. The regex for parsing the keyword options was missing the * character.

Link to redmine ticket: 6070

Describe changes:

  • Add multiplication operator to the parsing regex.

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the pull request number.

SV_REPO=
SV_BRANCH=pr/1244
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 6070

This commit adds support for the multiplication operator to byte-math.
The regex for parsing the keyword options was missing the `*` character.
@jlucovsky jlucovsky added the needs verify Needs (a) Suricata-verify test(s) label Jun 12, 2023
@jlucovsky jlucovsky requested a review from a team as a code owner June 12, 2023 13:44
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.flow.spare 2181816 2035897 93.31%

Pipeline 14439

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my quick feedback :
CI : I guess cocci need to be rerun
Code : looks good, and even if better in 7 ;-)
Commits segmentation : ok
Commit messages : ok
Git ID set : ok
CLA : ok
Doc update : none needed
Redmine ticket : ok
Rustfmt : no rust
Tests : ok
Dependencies added: none

@victorjulien
Copy link
Member

Is this a backport or should this have been against master?

@catenacyber
Copy link
Contributor

Is this a backport or should this have been against master?

This is not a backport.

This does not need to be against master.

Justification is in the redmine ticket :

Note that 7.0.x supports the * operator as the parser was rewritten.

@jasonish
Copy link
Member

Merged via #9023.

@jasonish jasonish closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs verify Needs (a) Suricata-verify test(s)
5 participants