Ci rustfmt v1 #9044
Closed
Ci rustfmt v1 #9044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
force-pushed
the
ci-rustfmt-v1
branch
from
b9390b6
to
a574ec2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9044 +/- ##
==========================================
+ Coverage 82.24% 82.29% +0.05%
==========================================
Files 969 969
Lines 273655 273654 -1
==========================================
+ Hits 225055 225208 +153
+ Misses 48600 48446 -154
Flags with carried forward coverage won't be shown. Click here to find out more. |
Files formatted need to remain formatted
catenacyber
force-pushed
the
ci-rustfmt-v1
branch
from
a574ec2
to
ec92a65
Compare
jasonish
reviewed
Jun 20, 2023
|
Information: QA ran without warnings. Pipeline 14755 |
jasonish
reviewed
Jun 22, 2023
jasonish
reviewed
Jun 22, 2023
| @@ -0,0 +1,10 @@ | |||
| r=0 | |||
| cat qa/rustfmt.txt | while read i; do | |||
| rustfmt $i; | |||
There was a problem hiding this comment.
I'd just call cargo fmt then check each file.
jasonish
reviewed
Jun 22, 2023
| @@ -0,0 +1,57 @@ | |||
| rust/derive/src/applayerframetype.rs | |||
There was a problem hiding this comment.
Maybe build this list within the context of the rust/ directory, as in where its valid to run cargo fmt.
jasonish
requested changes
Jun 22, 2023
Closed
|
replaced by #9072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None : QA
Describe changes: