New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5912 rfb skip v3 #9064
5912 rfb skip v3 #9064
Conversation
We only try to parse a small subset of what is possible in RFB. Currently we only understand some standard auth schemes and stop parsing when the server-client handshake is complete. Since in IPS mode returning an error from the parser causes drops that are likely uncalled for, we do not want to return errors when we simply do not understand what happens in the traffic.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9064 +/- ##
==========================================
- Coverage 82.35% 82.31% -0.04%
==========================================
Files 969 969
Lines 273655 273721 +66
==========================================
- Hits 225359 225325 -34
- Misses 48296 48396 +100
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sascha.
Could you just add a redmine ticket for this and reference it in the main commit message ?
Otherwise, all good for me.
CI : green
Code : a few questions
Commits segmentation : ok for me
Commit messages : still missing a ticket reference in the main commit
Git ID set : ok
CLA : ok
Doc update : none needed
Redmine ticket : needed, right ?
Rustfmt : ok
Tests : ok
Dependencies added: none
The redmine ticket was linked in the first original PR: #5912 I'll keep it tracked across PR iterations next time 👍🏻 -- and also open a new PR to include it in the main commit message. Thanks! |
New PR: #9071 |
Previous PR: #9041
Describe changes to previous PR:
Eq
Derive.rfb-events.rules
torules/Makefile.am
.