Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5912 rfb skip v4 #9071

Closed
wants to merge 3 commits into from
Closed

5912 rfb skip v4 #9071

wants to merge 3 commits into from

Commits on Jun 22, 2023

  1. rfb: be more strict parsing the version

    @satta
    satta committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    8bc37bc View commit details
    Browse the repository at this point in the history

  2. rfb: add myself as contributor

    @satta
    satta committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5e6269b View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. rfb: never return error on unknown traffic 

    We only try to parse a small subset of what is possible in
RFB. Currently we only understand some standard auth schemes
and stop parsing when the server-client handshake is complete.
Since in IPS mode returning an error from the parser causes
drops that are likely uncalled for, we do not want to return
errors when we simply do not understand what happens in the
traffic. This addresses Redmine OISF#5912.
    @satta
    satta committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    d0dc924 View commit details
    Browse the repository at this point in the history