Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect/http2: warning that http2.header is removed #9074

Closed
wants to merge 1 commit into from
Closed

detect/http2: warning that http2.header is removed #9074

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5780

Describe changes:

  • detect/http2: warning that http2.header is removed

See #8775 (comment)

Do we keep the deprecated keyword in 6 ?
Yes. But maybe it will be good to add a warning that it is removed in 7.

Modifies #9019 with review about the warning code

@catenacyber catenacyber requested a review from a team as a code owner June 26, 2023 13:10
@catenacyber catenacyber mentioned this pull request Jun 26, 2023
Closed
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.flow.spare 2181816 2046772 93.81%

Pipeline 14831

@victorjulien victorjulien mentioned this pull request Jun 27, 2023
Merged
@victorjulien
Copy link
Member

Merged in #9087, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@catenacyber @suricata-qa @victorjulien