configure: remove iconv check

[catenacyber]

Link to redmine ticket:
None, generic cleaning
Actually https://redmine.openinfosecfoundation.org/issues/4083

Describe changes:

• configure: remove iconv check

libhtp's configure does the work

[codecov]

Codecov Report

Merging #9151 (fdbd4ba) into master (9b09b29) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9151      +/-   ##
==========================================
- Coverage   82.34%   82.33%   -0.02%     
==========================================
  Files         968      968              
  Lines      273546   273546              
==========================================
- Hits       225247   225219      -28     
- Misses      48299    48327      +28     

Flag	Coverage Δ
fuzzcorpus	64.58% <ø> (-0.02%)	⬇️
suricata-verify	60.72% <ø> (-0.03%)	⬇️
unittests	62.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[jufajardini]

Who'd be a good reviewer for this?

[catenacyber]

You can do it : it simply removes 2 lines, and you can check that iconv is not used by Suricata itself

[jufajardini]

You can do it : it simply removes 2 lines, and you can check that iconv is not used by Suricata itself

Fair XD

Only seems to be used by Doxygen: https://github.com/OISF/suricata/blob/master/doxygen.cfg#L22
I don't know how our Doxygen documentation is generated. 🤔 could it be that it is there for the process of automatically generating those?

[catenacyber]

I would argue Suricata does not need iconv even if doxygen needs it

[jufajardini]

My local checks seem to indicate that this change can go :)

[victorjulien]

Originally added to fix build on freebsd, see c099349

[victorjulien]

Triggered a run on my qa to see how modern freebsd and openbsd like this change.

[victorjulien]

FreeBSD 12 for this PR (rebased to master):

  AR       libsuricata_c.a
  CCLD     suricata
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconv_open [--no-allow-shlib-undefined]
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconvctl [--no-allow-shlib-undefined]
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconv_close [--no-allow-shlib-undefined]
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconv [--no-allow-shlib-undefined]
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [Makefile:2857: suricata] Error 1
gmake[3]: Leaving directory '/var/tmp/gitlab_runner/builds/sP2xB2Af/0/inliniac/suricata-ci/suricata/suricata-7.0.0-rc3-dev/_build/sub/src'
gmake[2]: *** [Makefile:2682: all] Error 2
gmake[2]: Leaving directory '/var/tmp/gitlab_runner/builds/sP2xB2Af/0/inliniac/suricata-ci/suricata/suricata-7.0.0-rc3-dev/_build/sub/src'
gmake[1]: *** [Makefile:491: all-recursive] Error 1
gmake[1]: Leaving directory '/var/tmp/gitlab_runner/builds/sP2xB2Af/0/inliniac/suricata-ci/suricata/suricata-7.0.0-rc3-dev/_build/sub'
gmake: *** [Makefile:705: distcheck] Error 1

FreeBSD 13:

  AR       libsuricata_c.a
  CCLD     suricata
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconv_open [--no-allow-shlib-undefined]
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconvctl [--no-allow-shlib-undefined]
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconv_close [--no-allow-shlib-undefined]
ld: error: ../libhtp/htp/.libs/libhtp.so: undefined reference to libiconv [--no-allow-shlib-undefined]
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [Makefile:2857: suricata] Error 1
gmake[3]: Leaving directory '/var/tmp/gitlab_runner/builds/sF87JEwd/0/inliniac/suricata-ci/suricata/suricata-7.0.0-rc3-dev/_build/sub/src'
gmake[2]: *** [Makefile:2682: all] Error 2
gmake[2]: Leaving directory '/var/tmp/gitlab_runner/builds/sF87JEwd/0/inliniac/suricata-ci/suricata/suricata-7.0.0-rc3-dev/_build/sub/src'
gmake[1]: *** [Makefile:491: all-recursive] Error 1
gmake[1]: Leaving directory '/var/tmp/gitlab_runner/builds/sF87JEwd/0/inliniac/suricata-ci/suricata/suricata-7.0.0-rc3-dev/_build/sub'
gmake: *** [Makefile:705: distcheck] Error 1

[catenacyber]

ok @cccs-rtmorti would you add this 2-lines removal to your libhtp-rs PR ?