dcerpc incomplete api/v1 #9265
Closed
dcerpc incomplete api/v1 #9265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of own internal mechanism of buffering in case of fragmented data, use AppLayerResult::incomplete API to let the AppLayer Parser take care of it. This makes the memory use more efficient. Remove any unneeded variables and code with the introduction of this API. Ticket 5699
With the introduction of AppLayerResult::incomplete API, fragmented data is no longer handled fully in the dcerpc code making the tests about such data invalid. Ticket 5699
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 15344 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9265 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 968 968
Lines 273952 273714 -238
==========================================
- Hits 225807 225592 -215
+ Misses 48145 48122 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5699