Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eve/stats: log all stats, even those that are unscoped #9293

Closed
wants to merge 5 commits into from
Closed

eve/stats: log all stats, even those that are unscoped #9293

wants to merge 5 commits into from

Conversation

jlucovsky
Copy link
Contributor

Make sure that all stats are logged -- even those that are not scoped (missing the . -- e.g., mempressure_max vs decoder.pkts.

Link to redmine ticket: 6094

Describe changes:

  • Precalculate the statistic's short-name during registration
  • Use the short-name value to determine the scope.
  • Add unscoped stats to the "global" record; scoped stats are handled as they were previously.

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@jlucovsky
schema: Add memcap pressure values
389c299 
Issue: 6094

This commit extends the EVE schema with memcap_pressure values; these
are included in the stat event type records.
@jlucovsky
general/typo: Correct spelling/grammar issues
f7154be
@jlucovsky
mem/alloc: Replace malloc with calloc
847472c 
Minor cleanup so SCCalloc is used in preference to SCMalloc.
@jlucovsky
output/stats: Handle stat names w/out scope
b2cfab5 
Issue: 6094

Not all stat names are scoped, e.g. decoder.pkts is scoped to decoder;
mempressure_max is unscoped.

The concept of a short-name is added to the underlying stat structure so
- Calculation is done once, at stat registration time
- The output code can easily determine if a stat has a scope
@jlucovsky
general: Remove unused include files
310de75
@jlucovsky jlucovsky requested review from victorjulien and a team as code owners July 26, 2023 13:02
@jlucovsky jlucovsky mentioned this pull request Jul 26, 2023
Closed
@jlucovsky
Copy link
Contributor Author

Continued in #9294

@jlucovsky jlucovsky closed this Jul 26, 2023
@jlucovsky jlucovsky deleted the 6094/1 branch July 28, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@jlucovsky