Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update file keywords v3 #9327

Closed

Conversation

jmtaylor90
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

  • Update file.magic and file.name keyword information to reflect recent updates
  • Update libmagic dependency information and reference
  • Address review comments in doc: update file keywords v2 #9316

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Signed-off-by: jason taylor <jtfas90@gmail.com>
Signed-off-by: jason taylor <jtfas90@gmail.com>
Signed-off-by: jason taylor <jtfas90@gmail.com>
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your time incorporating all the feedback! :)

@jmtaylor90
Copy link
Contributor Author

jmtaylor90 commented Aug 7, 2023

Seeing as the code is being backported to the 6.x series, do we want a backport of these docs as well?

@jufajardini
Copy link
Contributor

Seeing as the code is being backported to the 6.x series, do we want a backport of these docs as well?

Yes, that'd be good, thanks :)

@victorjulien
Copy link
Member

Merged in #9355, thanks!

@jmtaylor90 jmtaylor90 deleted the doc-update-file-keywords-v3 branch August 8, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants